Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where did the icon go 😯 #19

Closed
2 tasks done
JorisDebonnet opened this issue Mar 5, 2018 · 3 comments
Closed
2 tasks done

Where did the icon go 😯 #19

JorisDebonnet opened this issue Mar 5, 2018 · 3 comments
Labels
affects/v4 complexity/low impact/low type/bug
Milestone
Recipe 4.0.4

Comments

@JorisDebonnet
Copy link

JorisDebonnet commented Mar 5, 2018 •
edited by dhensby
Loading

Well, I know where it went:

bundle.css contains li.class-ErrorPage>a .jstree-pageicon.
It needs to contain li.class-SilverStripe_ErrorPage_ErrorPage>a .jstree-pageicon instead.

(.. I don't know where the source of that bundle.css is :-/ and actually, this issue is probably also there for RedirectorPage and, uh, those other built-in ones)

PRs:
tractorcow pushed a commit to open-sausages/silverstripe-admin that referenced this issue Mar 5, 2018
BUG Fix page icons
985a0af 
Fixes silverstripe/silverstripe-errorpage#19
This was referenced Mar 5, 2018
Merged
Merged
@tractorcow
Copy link
Contributor

Fixed and PRs in comment at top.

@tractorcow
Copy link
Contributor

image

@tractorcow tractorcow reopened this Mar 5, 2018
@tractorcow
Copy link
Contributor

We'll need to keep this open until the PRs are merged. :)

@tractorcow tractorcow added this to the Recipe 4.0.4 milestone Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/low type/bug
Projects
None yet
Milestone
Recipe 4.0.4
Development

No branches or pull requests
2 participants
@tractorcow @JorisDebonnet