Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove TODO Comments #95

Merged
merged 1 commit into from
May 28, 2024
Merged

MNT Remove TODO Comments #95

merged 1 commit into from
May 28, 2024

Conversation

sabina-talipova
Copy link
Contributor

sabina-talipova
sabina-talipova commented Oct 11, 2023
View reviewed changes
src/Checks/CacheHeadersCheck.php
@@ -89,7 +89,6 @@ public function check()
$this->getMessage(),
];
} else {
// @todo Ability to return a warning
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #94

@GuySartorelli GuySartorelli changed the base branch from 3.0 to 3 May 28, 2024 23:12
GuySartorelli
GuySartorelli approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missed at the time - LGTM

@GuySartorelli GuySartorelli merged commit 9735f5d into silverstripe:3 May 28, 2024
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3.0/remove-todo branch May 28, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli