Bugfix #849: Set default Sort only when ParentID is available #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispenny
commented
Oct 4, 2021
Comment on lines
+298
to
+306
| if ($this->hasExtension(Versioned::class)) { | ||
| $records = Versioned::get_by_stage(BaseElement::class, Versioned::DRAFT); | ||
| } else { | ||
| $records = BaseElement::get(); | ||
| } | ||
|
|
||
| $records = $records->filter('ParentID', $this->ParentID); | ||
|
|
||
| $this->Sort = $records->max('Sort') + 1; |
There was a problem hiding this comment.
No changes here - just moved to "exit early" paradigm.
chrispenny
commented
Oct 4, 2021
Comment on lines
+293
to
+296
| // If no ParentID is currently set for the Element, then we don't want to define an initial Sort yet | ||
| if (!$this->ParentID) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
The guts of the change.
Rationale detailed here:
#849 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #849
Related to #931
Sortvalue until aParentIDis available on the Element.