DEP Use graphql 3 #851
DEP Use graphql 3 #851
Conversation
|
The issue is with silverstripe/recipe-cms:4.x-dev which we install on .travis.yml, not elemental itself so I don't want to touch this module Travis currently has a backlog of builds to run, though this branch is green on creative-commoners travis account https://travis-ci.com/github/creative-commoners/silverstripe-elemental/builds/201924599 |
|
Elemental does have a direct dependency on GraphQL though. I'm not as familiar with the decisions made here, but it does seem to me like this client-level abstraction you're proposing is just going to become a nightmare to maintain. |
|
Elemental requires versioned-admin which requires graphql is how things currently work. Graphql 4 compatibility in core modules was merged on 1.x-dev/4.x-dev branches in the last few days which has complicated travis builds for matrix's that install recipe 4.x-dev for the following modules:
I don't think it will? At this stage we're only expecting to have to update 3 travis files, and we'll probably be migrating to a shared travis config within the month which will make this sort of thing even easier |
|
Ok, when 4.8 is released what are you intending to do with this change? In my mind if we're supporting GraphQL 3 and 4 then it'd be worth running tests on both versions - at least for behat |
|
I'm not sure because I don't know if graphql will have a stable tag then. We will have the option of removing it because elemental will be compatible because of these unreleased commits on elemental 4.x-dev
If we wish to test both, then we could simply create another matrix entry to test on graphql 3 - silverstripe-admin does this now
|
emteknetnz
force-pushed
the
pulls/4.5/graphql3
branch
from
b5c7f70 to
12bce1d
Compare
emteknetnz
force-pushed
the
pulls/4.5/graphql3
branch
from
12bce1d to
fe85d4a
Compare
|
Chatted to @Cheddam about this, we've agreed to change this to making the change in composer.json |
|
Travis doesn't appear to be working on this repo/account? Travis is green on creative-commoners - https://travis-ci.com/github/creative-commoners/silverstripe-elemental |
This was originally added to the 4 release branch, and then removed prior to the 4.5.0 release through silverstripe#851 to simplify Travis builds. Explicitly declaring the module *doesn't* support GraphQL 4 is incorrect, and hinders early adoption - you'll need to run a "silverstripe/graphql:4.x-dev as 3.x-dev" dependency. It's also a different strategy compared to e.g. versioned-admin: silverstripe/silverstripe-versioned-admin@cae464f
|
I've sent a follow up to restore GraphQL 4 support: #865 @emteknetnz Please ping @unclecheese or myself when you make those kinds of changes, when there's a significant overlap with our work (and it reverts an earlier change by Aaron). |
This was originally added to the 4 release branch, and then removed prior to the 4.5.0 release through silverstripe#851 to simplify Travis builds for the release activity. Explicitly declaring the module *doesn't* support GraphQL 4 is incorrect, and hinders early adoption - you'll need to run a "silverstripe/graphql:4.x-dev as 3.x-dev" dependency. It's also a different strategy compared to e.g. versioned-admin: silverstripe/silverstripe-versioned-admin@cae464f Relies on silverstripe/silverstripe-travis-shared#4
* DEP Restore GraphQL 4 support This was originally added to the 4 release branch, and then removed prior to the 4.5.0 release through #851 to simplify Travis builds for the release activity. Explicitly declaring the module *doesn't* support GraphQL 4 is incorrect, and hinders early adoption - you'll need to run a "silverstripe/graphql:4.x-dev as 3.x-dev" dependency. It's also a different strategy compared to e.g. versioned-admin: silverstripe/silverstripe-versioned-admin@cae464f Relies on silverstripe/silverstripe-travis-shared#4 * DEP Change to recipe-testing See #865 (review)
Use graphql 3.x-dev when installing the 4.x-dev recipeSpecify graphql 3 in composer.json