Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP NEW Allow edit tabs to dispatch TabsActions #394

Conversation

raissanorth
Copy link
Contributor

{
'state/tabs/ActionTabs' : 'ActionTabs'
}
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a patch for the admin PR before it's in webpack config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to test the changes without having to rely on an PR to the webpack config repo just yet. I plan on removing this once the PR is not in WIP state any more.

@raissanorth raissanorth force-pushed the pulls/4/make-the-dropdown-buttons-do-stuff branch from c92bcd7 to f4417f5 Compare September 19, 2018 00:06
@raissanorth raissanorth force-pushed the pulls/4/make-the-dropdown-buttons-do-stuff branch from f4417f5 to 185c761 Compare September 19, 2018 04:49
@raissanorth
Copy link
Contributor Author

raissanorth commented Oct 3, 2018

Closing this for #428; the new approach connects Tabs to redux-form rather than connecting ElementActions to the Redux store. This will allow to change active tabs for individual elements rather than changing them all in unison.

@raissanorth raissanorth closed this Oct 3, 2018
@raissanorth raissanorth deleted the pulls/4/make-the-dropdown-buttons-do-stuff branch October 3, 2018 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants