FIX Don't try to save blocks in a readonly elemental area

[GuySartorelli]

Turns out when the field is read-only we don't have the schema data - but even if we did, we shouldn't try to save data for a read-only field.

Note this fixes two separate issues - please test both of them to ensure the fix works as expected in both scenarios.

Issues

• JS-Error blocks Fluent actions for unlocalised objects #1290
• Unable to restore pages from archive with ElementalArea extension applied silverstripe-versioned-admin#378

[emteknetnz]

Tested both scenarios, both are fixed by this PR

[andreaspiening]

Hi Guy,

this mr fixed an issue I had with the combination of elemental and advanced-workflow, where clicking the approve button failed with a JS error in the onbeforesubmitform hook, due to the form being readonly.

However I wonder if the onmatch hook needs the same treatment: it is triggering the same problem (accessing the the data-schema attribute, which is absent in the readonly form), hence showing an error in the console, though not having any negative impact on submitting of the form.

Andy

[GuySartorelli]

I wonder if the onmatch hook needs the same treatment: it is triggering the same problem (accessing the the data-schema attribute, which is absent in the readonly form), hence showing an error in the console, though not having any negative impact on submitting of the form.

If there's no actual problem other than an error in the console log, then yes technically it is a bug that should be fixed but the priority is too low for me to personally create a PR for it.