MNT Update test to reflect changes to template/model layers #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Oct 14, 2024
Comment on lines
-81
to
+82
| $this->assertEquals("DNADesign\Elemental\Tests\Src\TestPage", $ownerpage1); | ||
| $this->assertEquals("DNADesign\Elemental\Tests\Src\TestPage", $ownerpage2); | ||
| $this->assertInstanceOf(TestPage::class, $ownerpage1); | ||
| $this->assertInstanceOf(TestPage::class, $ownerpage2); |
There was a problem hiding this comment.
This was always just a bad test that relied on ModelData::__toString() returning the class name.
This change isn't necessary anymore since I had to revert the change to what that method returns, but I think this change is still objectively good and worth doing. Check the class to check the class, ya know?
Closed
23 tasks
GuySartorelli
force-pushed
the
pulls/6/refactor-template-layer
branch
from
ad9f36b to
5ba1514
Compare
emteknetnz
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies and reflects on changes in silverstripe/silverstripe-framework#11405
Issue