Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Deprecate GraphQL #1235

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/5/deprecate-graphql branch from eecb69c to 13a335b Compare August 15, 2024 02:46
@emteknetnz emteknetnz marked this pull request as ready for review August 16, 2024 04:56
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean you can't get elemental blocks in a front-end schema anymore without adding a bunch of boilerplate? Or was this all exclusively for the admin schema?

@emteknetnz emteknetnz force-pushed the pulls/5/deprecate-graphql branch from 13a335b to c3f3660 Compare August 19, 2024 03:03
@emteknetnz
Copy link
Member Author

Everything be removed was only intended for the admin schema

@emteknetnz
Copy link
Member Author

unit test failures should be resolved by silverstripe/silverstripe-versioned#464

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit bea53c5 into silverstripe:5 Aug 19, 2024
24 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/deprecate-graphql branch August 19, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants