Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Remove GraphQL #1220

Merged
merged 1 commit into from
Sep 2, 2024
Merged

API Remove GraphQL #1220

merged 1 commit into from
Sep 2, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 17, 2024 •
edited
Loading

@emteknetnz emteknetnz changed the title NEW Standardise controller endpoints NEW Standardise endpoints Jul 17, 2024
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch 2 times, most recently from 2542658 to 69c8c72 Compare July 17, 2024 04:42
@emteknetnz emteknetnz mentioned this pull request Jul 17, 2024
Closed
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch 2 times, most recently from 65b9272 to aaec782 Compare July 17, 2024 05:18
@emteknetnz emteknetnz changed the title NEW Standardise endpoints API Standardise endpoints Jul 17, 2024
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch 9 times, most recently from af828ad to b228d44 Compare July 18, 2024 22:51
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch from b228d44 to f6177e5 Compare July 22, 2024 05:41
@emteknetnz emteknetnz mentioned this pull request Jul 29, 2024
Closed
11 tasks
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch from f6177e5 to 0f2feff Compare July 30, 2024 06:16
@emteknetnz emteknetnz changed the title API Standardise endpoints API Remove GraphQL Jul 30, 2024
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch 6 times, most recently from abf81e7 to 7dace89 Compare August 2, 2024 12:31
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch 3 times, most recently from b54a2a7 to 96251ec Compare August 7, 2024 05:50
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch 5 times, most recently from d18d913 to 4d226bb Compare August 15, 2024 23:44
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch from 4d226bb to 05c7a18 Compare August 19, 2024 05:37
@emteknetnz emteknetnz marked this pull request as ready for review August 19, 2024 22:14
GuySartorelli
GuySartorelli requested changes Aug 20, 2024
View reviewed changes
client/src/state/history/revertToBlockVersionRequest.js Outdated Show resolved Hide resolved
src/Controllers/ElementalAreaController.php Outdated Show resolved Hide resolved
src/Controllers/ElementalAreaController.php Outdated Show resolved Hide resolved
src/Controllers/ElementalAreaController.php Outdated Show resolved Hide resolved
src/Controllers/ElementalAreaController.php Outdated Show resolved Hide resolved
src/Controllers/ElementalAreaController.php Outdated Show resolved Hide resolved
src/Models/BaseElement.php Show resolved Hide resolved
src/Models/BaseElement.php Outdated Show resolved Hide resolved
src/Models/BaseElement.php Outdated Show resolved Hide resolved
src/Models/BaseElement.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch 4 times, most recently from 81a055d to 4456547 Compare August 22, 2024 00:44
GuySartorelli
GuySartorelli requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to hit start review. Or rather GitHub didn't give me the option because I was responding in the regular view and not the files view. Hate that.

I only added this comment before noticing my blunder:

src/Models/BaseElement.php Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch from 4456547 to 5c09234 Compare August 22, 2024 07:37
GuySartorelli
GuySartorelli approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when all the other PRs are happy

@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch 9 times, most recently from c499cd2 to 1972ea6 Compare August 28, 2024 02:06
GuySartorelli
GuySartorelli approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the rebase, looks like the only change since my last approval was updating yarn lock. Approved.

@emteknetnz emteknetnz force-pushed the pulls/6/standardise-endpoints branch from 1972ea6 to fde6be7 Compare August 30, 2024 00:05
GuySartorelli
GuySartorelli approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved most recent changes

@GuySartorelli GuySartorelli merged commit 7eb74af into silverstripe:6 Sep 2, 2024
6 of 23 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/standardise-endpoints branch September 2, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli