Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Deprecate BaseElement::getDescription() #1196

Merged

Conversation

GuySartorelli
Copy link
Member

Replaces #953

This will free up Description to be used as a db column for blocks.
I had considered replacing getDescription() with geti18nDescription() to keep a method where the localised description could be fetched - but it seems unlikely that there are use cases to want to fetch that information directly outside of its use in the react components.

Issue

@emteknetnz emteknetnz merged commit 35c723d into silverstripe:5 May 29, 2024
13 checks passed
@emteknetnz emteknetnz deleted the pulls/5/deprecate-getdescription branch May 29, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants