ENH Refactor Element to use mutation hook #1174
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1164
Notes:
Update:
Don't merge this, just keep this here for reference
Got extremely stuck where somehow a second Element was being created though not actually used. Looks like it was being created as part of handleFormSchemaSubmitResponse() where state hooks were being set, though possibly something wasn't wrapped in useEffect() things got out of sync. This was detected because there was failing behat test where the page was submitted with invalid data, then immediately inline save the element, which should also fail and pop open the inline form. However the inline form wasn't popping open because the duplicated element was receiving the new props