Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseElement's canXYZ() methods can't be extended #29

Closed
robbieaverill opened this issue May 12, 2016 · 0 comments
Closed

BaseElement's canXYZ() methods can't be extended #29

robbieaverill opened this issue May 12, 2016 · 0 comments

Comments

@robbieaverill
Copy link
Contributor

They need to call the parent's methods before defining their own logic, otherwise the extension hook is not exposed.
robbieaverill added a commit to robbieaverill/silverstripe-elemental that referenced this issue May 12, 2016
@robbieaverill
FIX allow extensions to modify canXYZ methods
086d339 
* Resolves silverstripe#29
@robbieaverill robbieaverill mentioned this issue May 12, 2016
Merged
robbieaverill added a commit to robbieaverill/silverstripe-elemental that referenced this issue May 12, 2016
@robbieaverill
FIX allow extensions to modify canXYZ methods
9323d3b 
* Resolves silverstripe#29
* Use extendedCan() instead of parent::canXYZ
robbieaverill added a commit to robbieaverill/silverstripe-elemental that referenced this issue Jun 8, 2016
@robbieaverill
FIX allow extensions to modify canXYZ methods
2a56498 
* Resolves silverstripe#29
* Use extendedCan() instead of parent::canXYZ
@wilr wilr closed this as completed in #30 Jun 8, 2016
@emteknetnz emteknetnz mentioned this issue Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robbieaverill