API Update method signature for CMSEditLink

silverstripe · Aug 19, 2024 · e8b061b · e8b061b
1 parent 860df12
commit e8b061b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/docs/en/05_examples/00_elementalarea_with_dataobject.md b/docs/en/05_examples/00_elementalarea_with_dataobject.md
@@ -68,7 +68,7 @@ class BlogPost extends DataObject
 {
     // ...
 
-    public function CMSEditLink()
+    public function CMSEditLink(): ?string
     {
         // In this example we use BlogPostsAdmin class as Controller
         $admin = BlogPostsAdmin::singleton();

diff --git a/src/Models/BaseElement.php b/src/Models/BaseElement.php
@@ -888,7 +888,7 @@ public function isCMSPreview()
      * @return null|string
      * @throws \SilverStripe\ORM\ValidationException
      */
-    public function CMSEditLink($directLink = false)
+    public function CMSEditLink($directLink = false): ?string
     {
         // Allow for repeated calls to be returned from cache
         if (isset($this->cacheData['cms_edit_link'])) {

diff --git a/tests/Src/TestDataObjectWithCMSEditLink.php b/tests/Src/TestDataObjectWithCMSEditLink.php
@@ -27,7 +27,7 @@ class TestDataObjectWithCMSEditLink extends DataObject implements TestOnly
         'ElementalArea',
     ];
 
-    public function CMSEditLink()
+    public function CMSEditLink(): ?string
     {
         $link = Controller::join_links(
             'admin/',

diff --git a/tests/Src/TestPreviewableDataObject.php b/tests/Src/TestPreviewableDataObject.php
@@ -19,7 +19,7 @@ public function getMimeType()
         return null;
     }
 
-    public function CMSEditLink()
+    public function CMSEditLink(): ?string
     {
         return null;
     }