Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API phpunit 9 support #25

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as draft October 12, 2021 03:04
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch 3 times, most recently from 1dce007 to 4c81733 Compare October 19, 2021 01:29
@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 01:00
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from 4c81733 to 9966db1 Compare October 27, 2021 04:54
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 8761611 into silverstripe:2 Nov 1, 2021
@maxime-rainville maxime-rainville deleted the pulls/2/sapphire-test-nine branch November 1, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants