Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary safe session (using SDK fix) #38

Merged

Conversation

dnsl48
Copy link
Contributor

@dnsl48 dnsl48 commented Jul 11, 2019

Using binary safe data type for session storage

This should land into 4.1, since it's explicitly increasing minimal required AWS SDK version up to ~3.105

Copy link
Contributor

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't be removing classes in minor version bumps, it can only be done for major bumps.

@dnsl48
Copy link
Contributor Author

dnsl48 commented Dec 10, 2019

Fair enough. However, these classes were added in a patch release as a hotfix and marked as @internal. That isn't public API.
This patch is supposed to merely remove the hotfix after the bug was fixed upstream.

@dhensby
Copy link
Contributor

dhensby commented Dec 10, 2019

OK - if they were added in a patch release, they can be removed in a patch release

@dhensby dhensby merged commit 36871e6 into silverstripe:master Dec 10, 2019
@dnsl48 dnsl48 deleted the feature/sdk-session-binsafe branch December 10, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants