Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Set extension hook implementation visibility to protected #233

Merged
merged 1 commit into from
May 21, 2024
Merged

API Set extension hook implementation visibility to protected #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Extensions/ContentReviewDefaultSettings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public function OwnerUsers()
/**
* @param FieldList $fields
*/
public function updateCMSFields(FieldList $fields)
protected function updateCMSFields(FieldList $fields)
{
$helpText = LiteralField::create(
'ContentReviewHelp',
Expand Down
2 changes: 1 addition & 1 deletion src/Extensions/ContentReviewLeftAndMainExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class ContentReviewLeftAndMainExtension extends LeftAndMainExtension
*
* @param array &$clientConfig
*/
public function updateClientConfig(&$clientConfig)
protected function updateClientConfig(&$clientConfig)
{
$clientConfig['form']['ReviewContentForm'] = [
'schemaUrl' => $this->owner->Link('schema/ReviewContentForm')
Expand Down
2 changes: 1 addition & 1 deletion src/Extensions/ContentReviewOwner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class ContentReviewOwner extends DataExtension
"SiteTreeContentReview" => SiteTree::class,
];

public function updateCMSFields(FieldList $fields)
protected function updateCMSFields(FieldList $fields)
{
// Remove automatically scaffolded GridField in Member CMS fields
$fields->removeByName('SiteTreeContentReview');
Expand Down
6 changes: 3 additions & 3 deletions src/Extensions/SiteTreeContentReview.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public static function merge_owners(SS_List $groups, SS_List $members)
/**
* @param FieldList $actions
*/
public function updateCMSActions(FieldList $actions)
protected function updateCMSActions(FieldList $actions)
{
if (!$this->canBeReviewedBy(Security::getCurrentUser())) {
return;
Expand Down Expand Up @@ -326,7 +326,7 @@ public function OwnerUsers()
/**
* @param FieldList $fields
*/
public function updateSettingsFields(FieldList $fields)
protected function updateSettingsFields(FieldList $fields)
{
if ($this->owner->hasMethod('displayContentReview') && !$this->owner->displayContentReview()) {
return;
Expand Down Expand Up @@ -564,7 +564,7 @@ public function canBeReviewedBy(Member $member = null)
/**
* Set the review data from the review period, if set.
*/
public function onBeforeWrite()
protected function onBeforeWrite()
{
// Only update if DB fields have been changed
$changedFields = $this->owner->getChangedFields(true, 2);
Expand Down
Loading