Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Decouple from silverstripe/framework #82

Merged
merged 1 commit into from
Mar 30, 2023
Merged

DEP Decouple from silverstripe/framework #82

merged 1 commit into from
Mar 30, 2023

Conversation

GuySartorelli
Copy link
Member

This was referenced Mar 17, 2023
Closed
Open
@GuySartorelli GuySartorelli force-pushed the pulls/1.6/decouple-from-framework branch 3 times, most recently from 4843585 to ae86829 Compare March 19, 2023 22:25
sabina-talipova
sabina-talipova reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.
Just small question, why do we say Will be removed without equivalent functionality to replace it in MiddlewareCommon when we have __serialize and __unserialize methods?

@sabina-talipova
Copy link
Contributor

Could you rebase this PR, please.

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Mar 30, 2023 •
edited
Loading

Just small question, why do we say Will be removed without equivalent functionality to replace it in MiddlewareCommon when we have __serialize and __unserialize methods?

Because we stuffed up 😅
Technically that's not part of the concerns of this PR but I'll fix it here to save us some time.

@GuySartorelli GuySartorelli force-pushed the pulls/1.6/decouple-from-framework branch from ae86829 to e4a66ae Compare March 30, 2023 22:43
sabina-talipova
sabina-talipova approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good for me.

@sabina-talipova sabina-talipova merged commit 9b32897 into silverstripe:1.6 Mar 30, 2023
@sabina-talipova sabina-talipova deleted the pulls/1.6/decouple-from-framework branch March 30, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabina-talipova sabina-talipova sabina-talipova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @sabina-talipova