API Remove deprecated code #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/2/remove-deprecated-code
branch
from
a3be8ea to
40f964d
Compare
8 tasks
emteknetnz
requested changes
Dec 5, 2022
| @@ -117,9 +115,6 @@ public function checkForDeprecatedConfig($class, $name): void | |||
| { | |||
| $deprecated = $this->getClassConfig('__deprecated', true); | |||
| $data = $deprecated['config'][strtolower($class)][$name] ?? []; | |||
| if (!empty($data)) { | |||
There was a problem hiding this comment.
Please restore this block, this is not deprecated code, it's code that helps with identifying deprecated code
| * @param string $class | ||
| * @param string $name | ||
| * @param array $value - non-array values are @deprecated 1.12.0 | ||
| * @param array $value | ||
| */ | ||
| public function merge($class, $name, $value) |
There was a problem hiding this comment.
Suggested change
| public function merge($class, $name, $value) | |
| public function merge(string $class, string $name, array $value): static |
And delete the docblock @params now that we're strong typing this
There was a problem hiding this comment.
I'll have to update interface MutableConfigCollectionInterface as well.
There was a problem hiding this comment.
I've updated method signature in interface MutableConfigCollectionInterface and class MemoryConfigCollection
sabina-talipova
force-pushed
the
pulls/2/remove-deprecated-code
branch
2 times, most recently
from
667c1c1 to
7474b47
Compare
sabina-talipova
force-pushed
the
pulls/2/remove-deprecated-code
branch
from
7474b47 to
7a6bee5
Compare
emteknetnz
approved these changes
Dec 7, 2022
emteknetnz
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue