NEW Record deprecated config #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
force-pushed
the
pulls/1/deprecated-config
branch
from
f37d522 to
a03ba9f
Compare
GuySartorelli
requested changes
Oct 31, 2022
There was a problem hiding this comment.
We should have some unit tests in here - yes there are tests in framework but we should be testing here that the special __deprecated config gets set.
Nevermind, I've now seen the commend in the framework test about why that isn't feasible (in the future that sort of comment is probably best copied into this PR's description as well to ensure the reviewer is aware of it when looking at this PR on its own merits)
emteknetnz
force-pushed
the
pulls/1/deprecated-config
branch
from
a03ba9f to
e8576a5
Compare
GuySartorelli
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10543
Note reliant on another PR linked the main issue - CI is green when run together https://github.com/emteknetnz/silverstripe-installer/actions/runs/3342348741