ENH Do not emit deprecation notices for supported modules by default

silverstripe · Oct 17, 2024 · cd93a15 · cd93a15
1 parent 9c9b743
commit cd93a15
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -7,7 +7,8 @@
         "symfony/finder": "^6.1",
         "symfony/yaml": "^6.1",
         "marcj/topsort": "^2.0.0",
-        "psr/simple-cache": "^3.0.0"
+        "psr/simple-cache": "^3.0.0",
+        "silverstripe/framework": "^5.4.0"
     },
     "require-dev": {
         "phpunit/phpunit": "^9.6",

diff --git a/src/Transformer/YamlTransformer.php b/src/Transformer/YamlTransformer.php
@@ -10,6 +10,7 @@
 use Exception;
 use Closure;
 use SilverStripe\Config\Collections\MemoryConfigCollection;
+use SilverStripe\Dev\Deprecation;
 
 class YamlTransformer implements TransformerInterface
 {
@@ -135,6 +136,9 @@ private function checkForDeprecatedConfig(array $document, MutableConfigCollecti
         if (!($collection instanceof MemoryConfigCollection)) {
             return;
         }
+        if ($document['inSupportedModule'] && !Deprecation::getShowNoticesCalledFromSupportedCode()) {
+            return;
+        }
         foreach ($document['content'] as $key => $value) {
             if (!is_array($value)) {
                 continue;
@@ -240,8 +244,10 @@ protected function getNamedYamlDocuments()
                 );
             }
 
+            $filename = $document['filename'];
             $documents[$header['name']] = [
-                'filename' => $document['filename'],
+                'filename' => $filename,
+                'inSupportedModule' => Deprecation::fileIsInSupportedModule($filename),
                 'header' => $header,
                 'content' => $content,
             ];