API Make CMSMain more generic #3017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
GuySartorelli
force-pushed
the
pulls/6/generic-cmsmain
branch
7 times, most recently
from
2faf391 to
db3dcf7
Compare
This was referenced Oct 22, 2024
Closed
GuySartorelli
force-pushed
the
pulls/6/generic-cmsmain
branch
4 times, most recently
from
90b096b to
da66f41
Compare
This was referenced Nov 7, 2024
Closed
GuySartorelli
force-pushed
the
pulls/6/generic-cmsmain
branch
6 times, most recently
from
9475eee to
05eb821
Compare
GuySartorelli
force-pushed
the
pulls/6/generic-cmsmain
branch
3 times, most recently
from
d758dba to
5bcb887
Compare
GuySartorelli
force-pushed
the
pulls/6/generic-cmsmain
branch
from
5bcb887 to
cf093d1
Compare
GuySartorelli
force-pushed
the
pulls/6/generic-cmsmain
branch
7 times, most recently
from
3cca2a1 to
32bca92
Compare
Remove hardcoded references to pages and SiteTree Remove assumption that records are versioned Remove or validate assumptions about methods on the model class Improve general architecture of CMSMain
GuySartorelli
force-pushed
the
pulls/6/generic-cmsmain
branch
from
32bca92 to
586c258
Compare
|
Replaced with #3035 |
This was referenced Dec 8, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoded references to pages and SiteTree
Remove assumption that records are versioned
Remove or validate assumptions about methods on the model class
Improve general architecture of CMSMain
Relies on changes in silverstripe/silverstripe-admin#1837
Issue
SiteTreeinCMSMain#2947