Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove js prefix from require statements #2700

Merged
merged 1 commit into from
Nov 15, 2021
Merged

MNT Remove js prefix from require statements #2700

merged 1 commit into from
Nov 15, 2021

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 2, 2021 •
edited
Loading

@michalkleiner
Copy link
Contributor

I'd reword the commit to say remove .js extension but otherwise looks ok

@emteknetnz emteknetnz marked this pull request as draft November 2, 2021 22:37
@emteknetnz emteknetnz mentioned this pull request Nov 2, 2021
Merged
6 tasks
@emteknetnz emteknetnz marked this pull request as ready for review November 8, 2021 03:37
@emteknetnz emteknetnz mentioned this pull request Nov 8, 2021
Merged
6 tasks
maxime-rainville
maxime-rainville approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit db6b1c0 into silverstripe:4 Nov 15, 2021
@maxime-rainville maxime-rainville deleted the pulls/4/remove-js-prefix branch November 15, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @michalkleiner @maxime-rainville