Fix history comparison fields #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tractorcow
suggested changes
Feb 28, 2017
|
|
||
| public function transformReadonly(FieldList $fields) | ||
| { | ||
| foreach($fields as &$field) { |
There was a problem hiding this comment.
The problem with iterating over FieldList directly is that it only loops over the top level of fields.
Try foreach ($fields->dataFields() as $field) {, which has the added benefit of selecting only data fields, so you don't need the CompositeField filter.
There was a problem hiding this comment.
Thanks for fixing it :)
tractorcow
force-pushed
the
pulls/4.0/show-diff
branch
from
8922243 to
8537d6d
Compare
tractorcow
approved these changes
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so the fields no longer escape the
<ins>and<del>tags injected by the Differencer in the History view for pages.Original issue #1746
Also added some unit tests for this.