Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API phpunit9 support #255

Merged
merged 1 commit into from
Nov 1, 2021
Merged

API phpunit9 support #255

merged 1 commit into from
Nov 1, 2021

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Oct 12, 2021
Closed
93 tasks
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch 5 times, most recently from 33fefd7 to 00883d5 Compare October 19, 2021 01:34
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch 7 times, most recently from 317c477 to b202027 Compare October 24, 2021 02:01
@emteknetnz emteknetnz marked this pull request as ready for review October 27, 2021 21:26
maxime-rainville
maxime-rainville requested changes Nov 1, 2021
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the composer constraint. The rest can be address at our convenience.

composer.json Outdated
@@ -28,7 +28,7 @@
"ext-json": "*"
},
"require-dev": {
"sminnee/phpunit": "^5",
"phpunit/phpunit": "^9",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"phpunit/phpunit": "^9",
"phpunit/phpunit": "^9.5",

Maybe add a PHP constraint as well.

Copy link
Member Author

@emteknetnz emteknetnz Nov 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

tests/Page/CKANRegistryPageControllerTest.php Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from b202027 to b5d388b Compare November 1, 2021 04:29
maxime-rainville
maxime-rainville approved these changes Nov 1, 2021
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 2ed25df into silverstripe:1 Nov 1, 2021
@maxime-rainville maxime-rainville deleted the pulls/1/sapphire-test-nine branch November 1, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville