MNT Use React Testing Library #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
force-pushed
the
pulls/2.0/testing-library
branch
3 times, most recently
from
06aea8f to
1be58f8
Compare
emteknetnz
commented
Apr 6, 2023
| { code: 403, message: 'You do not have access to view this campaign.' }, | ||
| { code: 404, message: 'The campaign you are looking for can not be found.' }, | ||
| { code: 500, message: 'Something went wrong.' }, | ||
| ].forEach(({ code, message }) => { |
There was a problem hiding this comment.
I changed it.each() to .forEach() ... it() because these tests were weirdly hanging in my terminal even with all the code inside the loop commented out.
I ended up refactoring the syntax a little elsewhere, though it's still the same test
emteknetnz
force-pushed
the
pulls/2.0/testing-library
branch
3 times, most recently
from
29f2c2c to
3a32d33
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/2.0/testing-library
branch
from
3a32d33 to
8065d8e
Compare
emteknetnz
force-pushed
the
pulls/2.0/testing-library
branch
6 times, most recently
from
aee3e57 to
c00af93
Compare
emteknetnz
force-pushed
the
pulls/2.0/testing-library
branch
from
c00af93 to
3cb0995
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1503