BUG: Do not render campaign toolbar if there are no items in it yet #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScopeyNZ
reviewed
Sep 1, 2018
| @@ -386,6 +386,9 @@ class CampaignAdminList extends Component { | |||
| } | |||
| ); | |||
|
|
|||
| let items = this.getItems(); | |||
There was a problem hiding this comment.
In this case items can be a const too 🙂
dhensby
force-pushed
the
pulls/1/113-conditionally-hide-campaign-toolbar
branch
from
0f2267f to
7052780
Compare
|
Updated, but I think that it's likely the behat test will fail again - I think something isn't quite working right here? |
bergice
force-pushed
the
pulls/1/113-conditionally-hide-campaign-toolbar
branch
from
7052780 to
f5869a5
Compare
lukereative
approved these changes
Sep 13, 2018
lukereative
deleted the
pulls/1/113-conditionally-hide-campaign-toolbar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.