Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API phpunit9 support #661

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/3/sapphire-test-nine branch 4 times, most recently from 540c554 to 127a209 Compare October 19, 2021 01:33
@emteknetnz emteknetnz force-pushed the pulls/3/sapphire-test-nine branch from 127a209 to d7a6480 Compare October 22, 2021 05:24
@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 08:32
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to make the PHPUnit constraint ^9.5. Maybe add the PHP constraint while you're in there.

composer.json Outdated
@@ -15,7 +15,7 @@
"silverstripe/asset-admin": "^1.0"
},
"require-dev": {
"sminnee/phpunit": "^5.7",
"phpunit/phpunit": "^9",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"phpunit/phpunit": "^9",
"phpunit/phpunit": "^9.5",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@emteknetnz emteknetnz force-pushed the pulls/3/sapphire-test-nine branch from d7a6480 to d8ecb77 Compare November 1, 2021 04:27
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 363a115 into silverstripe:3 Nov 1, 2021
@maxime-rainville maxime-rainville deleted the pulls/3/sapphire-test-nine branch November 1, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants