-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API phpunit9 support #661
API phpunit9 support #661
Conversation
540c554
to
127a209
Compare
127a209
to
d7a6480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to make the PHPUnit constraint ^9.5
. Maybe add the PHP constraint while you're in there.
composer.json
Outdated
@@ -15,7 +15,7 @@ | |||
"silverstripe/asset-admin": "^1.0" | |||
}, | |||
"require-dev": { | |||
"sminnee/phpunit": "^5.7", | |||
"phpunit/phpunit": "^9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"phpunit/phpunit": "^9", | |
"phpunit/phpunit": "^9.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
d7a6480
to
d8ecb77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue silverstripe/silverstripe-framework#10019