Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Emails are arrays in TestMailer #232

Merged
merged 1 commit into from
Oct 27, 2022
Merged

FIX Emails are arrays in TestMailer #232

merged 1 commit into from
Oct 27, 2022

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Oct 27, 2022 •
edited
Loading

Fixes https://github.com/silverstripe/silverstripe-installer/actions/runs/3285991111/jobs/5499431854 and https://github.com/silverstripe/silverstripe-admin/actions/runs/3316905244/jobs/5499433811

SilverStripe\BehatExtension\Context\EmailContext::thereIsAnEmailFromToTitled()
Type error: SilverStripe\BehatExtension\Utility\TestMailer::findEmail(): Return value must be of type ?array, stdClass returned (Behat\Testwork\Call\Exception\FatalThrowableError)

Notes

Rerun the broken builds in admin and installer after merging this PR

Parent issue

michalkleiner
michalkleiner approved these changes Oct 27, 2022
View reviewed changes
Copy link

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michalkleiner
Copy link

@GuySartorelli back to you

@GuySartorelli GuySartorelli merged commit 3e9e446 into silverstripe:5 Oct 27, 2022
@GuySartorelli GuySartorelli deleted the pulls/5/fix-builds branch October 27, 2022 01:54
@GuySartorelli GuySartorelli mentioned this pull request Jan 27, 2023
Merged
emteknetnz pushed a commit that referenced this pull request Jan 29, 2023
@GuySartorelli
FIX Emails are arrays
73126ea 
Work missed during #232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @michalkleiner