Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW add iClickOnTheElementConfirmingTheDialog #202

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Apr 15, 2021

Issue #200

Makes sense to include this as well while we're doing this. This was in silverstripe-cms. There are a few other 'confirming the dialog' functions in BasicContext

Tag 4.4.0 after merge

@emteknetnz emteknetnz mentioned this pull request Apr 15, 2021
14 tasks
@emteknetnz emteknetnz changed the base branch from 4.3 to 4 April 15, 2021 01:54
@emteknetnz emteknetnz force-pushed the pulls/4.3/click-element-confirm-dialog branch from a1e3e41 to c754d70 Compare April 15, 2021 01:58
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@maxime-rainville maxime-rainville merged commit 91be987 into silverstripe:4 Apr 15, 2021
@maxime-rainville maxime-rainville deleted the pulls/4.3/click-element-confirm-dialog branch April 15, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants