FIX | TestMailer uses new testsession APIs for handling state #188
Conversation
| @@ -94,6 +94,6 @@ protected function saveEmail($data) | |||
| $state->emails = array(); | |||
| } | |||
| $state->emails[] = array_filter($data); | |||
| $this->testSessionEnvironment->applyState($state); | |||
| $this->testSessionEnvironment->saveState($state); | |||
There was a problem hiding this comment.
The change looks OK. The doc blocks aren't particularly useful and I'm not familiar with the difference, but presumably this has been tested in behat and fixes a problem, so LGTM
|
Would you mind fixing the builds to ensure they're still green? This branch is for SilverStripe 5.x, so you may want to retarget the PR. The Travis config needs recipe constraints changed from 2.x to 5.x |
|
sure, will do, thank you for taking a look :) |
|
@dnsl48 Do you know what specifically this was solving? Was there a bug that this fixes? I'm inclined to close this PR given we've been running behat tests for 4+ years since the PR was opened and this hasn't seemed to be a problem. |
|
Hey @GuySartorelli, sorry, I don't remember the exact details. |
This PR is a follow up on silverstripe/silverstripe-testsession#65