Merge pull request #291 from creative-commoners/pulls/6/php84

API Explicity mark nullable parameters for PHP 8.4
silverstripe · Dec 2, 2024 · 9ba0516 · 9ba0516
2 parents 3e4bb89 + ec7ccc5
commit 9ba0516
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Context/SilverStripeContext.php b/src/Context/SilverStripeContext.php
@@ -89,7 +89,7 @@ abstract class SilverStripeContext extends MinkContext implements SilverStripeAw
      *
      * @param   array   $parameters     context parameters (set them up through behat.yml)
      */
-    public function __construct(array $parameters = null)
+    public function __construct(?array $parameters = null)
     {
         if (!preg_match('#[\\\]FeatureContext$#', get_class($this))) {
             throw new InvalidArgumentException(

diff --git a/src/Extension.php b/src/Extension.php
@@ -165,7 +165,7 @@ public function configure(ArrayNodeDefinition $builder)
                 end()->
                 scalarNode('error_reporting')->
                     info('Call executor will catch exceptions matching this level')->
-                    defaultValue(E_ALL | E_STRICT)->
+                    defaultValue(E_ALL)->
                 end()->
                 scalarNode('retry_seconds')->
                     info('Number of seconds that @retry tags will retry for')->

diff --git a/src/Utility/TestMailer.php b/src/Utility/TestMailer.php
@@ -31,7 +31,7 @@ public function __construct(
         $this->testSessionEnvironment = TestSessionEnvironment::singleton();
     }
 
-    public function send(RawMessage $message, Envelope $envelope = null): void
+    public function send(RawMessage $message, ?Envelope $envelope = null): void
     {
         parent::send($message, $envelope);
         /** @var Email $email */