Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Handle nullable $original object argument in onAfterPublish #20

Merged
merged 2 commits into from
Mar 25, 2018
Merged

FIX Handle nullable $original object argument in onAfterPublish #20

merged 2 commits into from
Mar 25, 2018

Conversation

robbieaverill
Copy link
Contributor

@robbieaverill robbieaverill commented Mar 23, 2018 •
edited
Loading

Resolves #19

@robbieaverill
Add test to cover nullable $original when publishing a page for the f…
37f0f3f 
…irst time
@robbieaverill
FIX Handle nullable $original object argument in onAfterPublish
7e9f6ce 
Also minor refactor of logic around logging original EditorGroups() ID and Title
@robbieaverill robbieaverill changed the title Add test to cover nullable $original when publishing a page for the first time FIX Handle nullable $original object argument in onAfterPublish Mar 23, 2018
@robbieaverill robbieaverill mentioned this pull request Mar 25, 2018
Closed
@NightJar NightJar merged commit d632113 into silverstripe:2.1 Mar 25, 2018
@NightJar NightJar deleted the pulls/2.1/nullable-original branch March 25, 2018 21:35
@robbieaverill robbieaverill mentioned this pull request Mar 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NightJar NightJar NightJar approved these changes

Assignees
No one assigned
Labels
affects/v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbieaverill @NightJar