Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Multi HTML entities in image shortcodes #565

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Aug 7, 2023

Description

  • Turn off double_encode for image attributes in ImageShortcodeProvider

Parent issue

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks okay and seems to be necessary. Just one small change here.

src/Shortcodes/ImageShortcodeProvider.php Show resolved Hide resolved
@GuySartorelli
Copy link
Member

Please also add a behat test for this - or a unit test if you can find a way to do that cleanly.

@sabina-talipova sabina-talipova force-pushed the pulls/1.13/shortcods-multi-html-entities branch from 57c6adf to d560dd4 Compare August 7, 2023 23:04
@sabina-talipova
Copy link
Contributor Author

Add behat test in asset-admin silverstripe/silverstripe-asset-admin#1376

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge with the related PRs.

@GuySartorelli GuySartorelli merged commit 676924d into silverstripe:1.13 Aug 8, 2023
@GuySartorelli GuySartorelli deleted the pulls/1.13/shortcods-multi-html-entities branch August 8, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants