Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix tests to work with no trailing slash on base url #537

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jan 12, 2023

silverstripe/silverstripe-framework#10538 makes Director::absoluteBaseURL() not include a trailing slash by default. This PR updates relevant tests to not explicitly expect trailing slashes.

This PR can be merged independently of the other PRs, since it is ultimately just promoting best practices in our tests.

Parent issue

@GuySartorelli GuySartorelli merged commit 8a3278e into silverstripe:2 Jan 20, 2023
@GuySartorelli GuySartorelli deleted the pulls/2/fix-tests branch January 20, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants