NEW Move the replace file into the more options action set #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
suggested changes
Oct 11, 2018
| @@ -70,6 +70,15 @@ class AssetDropzone extends Component { | |||
| } | |||
| } | |||
|
|
|||
| componentDidUpdate() { | |||
| // Reattach name to hiddenFileInput as dropzone recreates this element after each upload | |||
| const name = this.props.name; | |||
There was a problem hiding this comment.
We'd prefer this to be destructured: const { name } = this.props;
| const hiddenFileInput = document.querySelector('.dz-input-PreviewImage'); | ||
|
|
||
| // Trigger a click on Dropzone's hidden file input in order to upload an image | ||
| hiddenFileInput.click(); |
There was a problem hiding this comment.
It's probably worth checking that hiddenFileInput is resolved before calling click on it
code/Forms/FileFormFactory.php
Outdated
| */ | ||
| protected function getReplaceFileAction($record) | ||
| { | ||
| $action = FormAction::create('replacefile', 'Replace file') |
There was a problem hiding this comment.
Can you please make the field title translatable?
|
Also looks the tests need some love =) |
|
Would be good to get this into the |
sachajudd
force-pushed
the
pulls/1/replace-file
branch
from
84af47b to
7a06d1d
Compare
|
Sounds good @unclecheese, I'll get on to looking at the tests 🙂 |
sachajudd
force-pushed
the
pulls/1/replace-file
branch
2 times, most recently
from
01a63f4 to
6423656
Compare
sachajudd
force-pushed
the
pulls/1/replace-file
branch
from
6423656 to
f2b9ac0
Compare
bergice
approved these changes
Oct 26, 2018
bergice
approved these changes
Oct 29, 2018
|
Looking good. I'm going to add a behat test for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #757