BUG Ensure that uploads of duplicate files detect existing filenames properly #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tractorcow, thanks for your PR! By analyzing the blame information on this pull request, I identified @chillu and @sminnee to be potential reviewers |
tractorcow
force-pushed
the
pulls/4.0/fix-file-create
branch
from
27b98cc to
522f454
Compare
|
There's a bug in core that needs fixing; Folder::validate() doesn't bypass extension checking, so it will fail validation in some cases. |
BUG Fix issue with file duplication on upload
tractorcow
force-pushed
the
pulls/4.0/fix-file-create
branch
from
522f454 to
b4c9a53
Compare
Fix merged in silverstripe/silverstripe-framework#6056 |
|
Reviewing this code, it seems as though we've missed a feature in However, this PR ensure that asset-admin does what it is supposed to: perform a context-aware |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.