Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Add @retry to behat feature files #1451

Merged
merged 1 commit into from
Apr 11, 2024
Merged

MNT Add @retry to behat feature files #1451

merged 1 commit into from
Apr 11, 2024

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/silverstripe-admin#1671

Most the feature files already had a @retry annotation

@emteknetnz emteknetnz mentioned this pull request Apr 4, 2024
Closed
@emteknetnz
Copy link
Member Author

Behat failure is ... ironic

Probably still worth merging even though it clearly does not 100% solve the isuee

GuySartorelli
GuySartorelli approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing will ever 100% resolve intermittent failures - but this should help mitigate them to some extent.
LGTM, merge on green

@GuySartorelli GuySartorelli merged commit 3fac9e5 into silverstripe:2.2 Apr 11, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2.2/behat-retry branch April 11, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli