Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Use SearchableMultiDropdownField #1424

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 27, 2023

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a dependency bump for admin and framework.

@emteknetnz emteknetnz force-pushed the pulls/2/selectorfield branch from 4525461 to 616e78a Compare December 12, 2023 21:39
@emteknetnz
Copy link
Member Author

Have updated composer.json

composer.json Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/2/selectorfield branch from 616e78a to 32480e2 Compare December 13, 2023 01:16
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once admin and framework PRs are merged

@GuySartorelli GuySartorelli merged commit 68b3ce4 into silverstripe:2 Dec 14, 2023
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2/selectorfield branch December 14, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants