Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW Select all and clear all functionality #1418

Merged
merged 1 commit into from
Nov 7, 2023
Merged

NEW Select all and clear all functionality #1418

merged 1 commit into from
Nov 7, 2023

Conversation

emteknetnz
Copy link
Member

Issue #546

@emteknetnz emteknetnz force-pushed the pulls/2/select-all branch 2 times, most recently from 41fac98 to 9d8c8b6 Compare November 7, 2023 02:26
@emteknetnz emteknetnz mentioned this pull request Nov 7, 2023
Closed
@emteknetnz
Copy link
Member Author

emteknetnz commented Nov 7, 2023 •
edited
Loading

Has been designed reviewed by Cassie and approved via slack as at commit a43a2ae

@emteknetnz emteknetnz force-pushed the pulls/2/select-all branch 2 times, most recently from 780adc2 to df47127 Compare November 7, 2023 06:27
@emteknetnz emteknetnz marked this pull request as ready for review November 7, 2023 06:35
GuySartorelli
GuySartorelli approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works well locally.

@GuySartorelli GuySartorelli merged commit 95e98a7 into silverstripe:2 Nov 7, 2023
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2/select-all branch November 7, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli