MNT Fix behat test #1405
Merged
MNT Fix behat test #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/2.0/fix-behat
branch
from
a0d0a27 to
27e2de2
Compare
GuySartorelli
commented
Oct 3, 2023
There was a problem hiding this comment.
Not sure why the css file was changed, but the js job failed at first and after running yarn build I got this changed file which matches the sha1sum of the original js build (see https://github.com/silverstripe/silverstripe-asset-admin/actions/runs/6387816339/job/17337061941)
emteknetnz
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably caused by a bad merge-up. The TinyMCE 4 selector was being used instead of the TinyMCE 6 one.
Issue