Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Broken builds #1323

Merged
merged 1 commit into from
Jan 20, 2023
Merged

MNT Broken builds #1323

merged 1 commit into from
Jan 20, 2023

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jan 19, 2023 •
edited
Loading

Issue https://github.com/silverstripeltd/product-issues/issues/659

Fixes Error: Call to undefined method GraphQL\Type\Definition\FieldDefinition::create()

Broken JS tests are unrelated

@emteknetnz emteknetnz marked this pull request as ready for review January 19, 2023 04:04
maxime-rainville
maxime-rainville approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit e8c7c31 into silverstripe:2 Jan 20, 2023
@maxime-rainville maxime-rainville deleted the pulls/2/broken-builds branch January 20, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville