FIX Correctly reset file details after bulk publish #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error from https://github.com/silverstripe/silverstripe-asset-admin/actions/runs/3726649898/jobs/6320236803
When bulk publishing or bulk unpublishing files, the file details screen wasn't being updated.
This is because react-router now slightly defers its navigation events. If two navigation events occur immediately after one another, the pending navigation is effectively cancelled. So we need to defer the second navigation until the first has finished.
Ultimately it would be better to just re-render the details screen whenever details change,taking advantage of react's state system, but that would require an extensive refactor and partial rewrite of the gallery that I'm just not prepared to do right now.
Parent issue