Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Update deprecations #1302

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

emteknetnz
Copy link
Member

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version numbers are incorrect - use 1 major version numbering instead. This will also need to be applied to any other deprecation notices in this module.

@emteknetnz emteknetnz force-pushed the pulls/1/deprecated branch 3 times, most recently from 2a1cb91 to b2867d5 Compare October 25, 2022 02:17
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOG

@GuySartorelli GuySartorelli merged commit ce33714 into silverstripe:1 Oct 25, 2022
@GuySartorelli GuySartorelli deleted the pulls/1/deprecated branch October 25, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants