FIX Update plugins to work with tinymce 6 #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
GuySartorelli
force-pushed
the
pulls/2/tinymce6
branch
4 times, most recently
from
38264af to
782f2ae
Compare
GuySartorelli
force-pushed
the
pulls/2/tinymce6
branch
from
782f2ae to
f381cc9
Compare
GuySartorelli
force-pushed
the
pulls/2/tinymce6
branch
from
f381cc9 to
67d6966
Compare
|
Note: The old behat selection logic stopped working - it's not really clear why, but the new logic is much more vanilla (doesn't rely on anything from the editor other than grabbing the internal document) so should be even more reliable than the old implementation, |
|
Needs silverstripe/silverstripe-framework#10508 and silverstripe/silverstripe-admin#1367 merged to go green, but tests are passing locally. |
sabina-talipova
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
The branch will be merged after merging of silverstripe-admin and silverstripe-framework new changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update plugins to with with tinymce6
Parent issue