Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Replace ADMIN permissions with less permissions in Behat test #1292

Merged
merged 1 commit into from
Sep 15, 2022
Merged

ENH Replace ADMIN permissions with less permissions in Behat test #1292

merged 1 commit into from
Sep 15, 2022

Conversation

sabina-talipova
Copy link
Contributor

Description

Replace user with "Admin" permissions to user with "Editor" permissions.

Parent issue

@sabina-talipova sabina-talipova mentioned this pull request Aug 31, 2022
Closed
25 tasks
@sabina-talipova sabina-talipova force-pushed the pulls/1/review-behat-tests branch 6 times, most recently from aac01e7 to a3319fe Compare September 8, 2022 03:15
@GuySartorelli
Copy link
Member

Tests are still failing.

@sabina-talipova sabina-talipova force-pushed the pulls/1/review-behat-tests branch from a3319fe to a2037b7 Compare September 14, 2022 02:15
@sabina-talipova
Copy link
Contributor Author

Fixed spelling mistake.

GuySartorelli
GuySartorelli requested changes Sep 14, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some areas that look like they could be tightened up a bit - but if I'm wrong and those permissions are required just say so 👍

tests/behat/features/multi-file-upload-field.feature Outdated Show resolved Hide resolved
tests/behat/features/manage-file-permissions.feature Outdated Show resolved Hide resolved
tests/behat/features/file-details.feature Outdated Show resolved Hide resolved
tests/behat/features/single-file-upload-field.feature Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/1/review-behat-tests branch from a2037b7 to 4d5bf8c Compare September 14, 2022 04:02
@sabina-talipova sabina-talipova force-pushed the pulls/1/review-behat-tests branch from 4d5bf8c to a2c3dc4 Compare September 15, 2022 00:05
@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Sep 15, 2022 •
edited
Loading

#1292 (comment)
Sorry, my fault.
Since Company has Versioned extension, user should have a following permissions 'CMS_ACCESS_LeftAndMain', 'CMS_ACCESS_CMSMain', 'VIEW_DRAFT_CONTENT'. I left "Access to 'Pages' section" for this.
Now I replaced it with 'VIEW_DRAFT_CONTENT'.

@GuySartorelli GuySartorelli merged commit b90b60f into silverstripe:1 Sep 15, 2022
@GuySartorelli GuySartorelli deleted the pulls/1/review-behat-tests branch September 15, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli