MNT Compatibility with webonyx/graphql-php v14 #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Apr 12, 2022
There was a problem hiding this comment.
The same discussion about the FakeResolveInfo class in this module vs the one in silverstripe/silverstripe-graphql as discussed in silverstripe/silverstripe-elemental#973 applies here.
emteknetnz
force-pushed
the
pulls/1/webonyx
branch
from
d4cdbc8 to
214d81a
Compare
|
Looks like you missed a couple of |
emteknetnz
force-pushed
the
pulls/1/webonyx
branch
from
214d81a to
e2c6d47
Compare
GuySartorelli
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10250