NEW Use embed/embed v4 #1254
Merged
NEW Use embed/embed v4 #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
force-pushed
the
pulls/1/embed
branch
from
61ee159 to
17f18a0
Compare
maxime-rainville
requested changes
Mar 11, 2022
|
|
||
| use Exception; | ||
|
|
||
| class InvalidUrlException extends Exception |
There was a problem hiding this comment.
Why are we creating this exception?
There was a problem hiding this comment.
Commented in reply below
emteknetnz
force-pushed
the
pulls/1/embed
branch
3 times, most recently
from
230969f to
56480fc
Compare
maxime-rainville
requested changes
Mar 16, 2022
emteknetnz
force-pushed
the
pulls/1/embed
branch
from
56480fc to
4821b46
Compare
|
Have renamed to Note there's something of an unavoidable (semver breaking?) API change in that the Exception thrown has changed. It's unavoidable because the old Exception came from embed/embed v3, which no longer exists. |
maxime-rainville
requested changes
Mar 19, 2022
emteknetnz
force-pushed
the
pulls/1/embed
branch
from
4821b46 to
e049bc7
Compare
maxime-rainville
approved these changes
Mar 23, 2022
|
Build is failing because it's still trying to install an older version of frameworktest. I took the liberty to bump it up |
maxime-rainville
force-pushed
the
pulls/1/embed
branch
from
3f079bb to
3546bd7
Compare
|
Actually, the framewortest version got fixed in #1259 already. I removed my extra commit, merged up the other fixed and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10243
Requires silverstripe/silverstripe-framework#10244