Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API phpunit9 support #1237

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as draft October 11, 2021 04:56
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch 12 times, most recently from 4b5eab6 to e63b640 Compare October 19, 2021 01:26
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from e63b640 to 09bbca1 Compare October 19, 2021 03:07
@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 00:59
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch 2 times, most recently from 8901a82 to 18e455d Compare October 27, 2021 04:49
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from 18e455d to 02b1a5d Compare October 27, 2021 05:23
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good merge on green.

@@ -4,7 +4,9 @@ Standard module phpunit configuration.
Requires PHPUnit ^5.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ditch this comment.

@emteknetnz emteknetnz merged commit 0143636 into silverstripe:1 Oct 27, 2021
@emteknetnz emteknetnz deleted the pulls/1/sapphire-test-nine branch October 27, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants