Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix details button not showing on different pages #1153

Closed

Conversation

bergice
Copy link
Contributor

@bergice bergice commented Nov 2, 2020

Resolves #1136

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not going to work. There's some scenarios where file will is undefined and it will crash:

  • In the modal navigate to a folder with 50+ children
  • Start editing a file or a folder in the editor
  • Navigate to a different page

https://youtu.be/q5cae8h4UmQ

@bergice bergice force-pushed the fix-details-button branch from 6fb2ad9 to 638f9dc Compare November 9, 2020 08:03
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's still not going to work. The insert modal allows you to edit folders and it needs to know it's a folder to suppress the "Details" button. This PR introduces the following bug.

https://youtu.be/cr4KG93QgN0

  • In the "Insert Image" modal, navigate to a directory with 50+ folders/files
  • Edit a folder.
  • Use the pagination to access more files/folder.

Expected result: the editor is still present allowing you to edit the folder and an the "Details" button doesn't show.
Actual result: The "Details" button start showing

@bergice bergice closed this Nov 10, 2020
@maxime-rainville maxime-rainville deleted the fix-details-button branch July 12, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"(Edit) Details" button only visible if grid shows the page of selected file
2 participants