Fix some linting issue

silverstripe · Oct 8, 2019 · ccbb7a4 · ccbb7a4
1 parent 66de05b
commit ccbb7a4
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 25 deletions.
diff --git a/client/dist/js/bundle.js b/client/dist/js/bundle.js
diff --git a/client/dist/styles/bundle.css b/client/dist/styles/bundle.css
diff --git a/client/src/containers/Editor/Editor.js b/client/src/containers/Editor/Editor.js
@@ -17,6 +17,7 @@ class Editor extends Component {
 
     this.handleCancelKeyDown = this.handleCancelKeyDown.bind(this);
     this.handleClose = this.handleClose.bind(this);
+    this.handleDelete = this.handleDelete.bind(this);
     this.handleSubmit = this.handleSubmit.bind(this);
     this.handleAction = this.handleAction.bind(this);
     this.handleLoadingSuccess = this.handleLoadingSuccess.bind(this);
@@ -51,30 +52,11 @@ class Editor extends Component {
 
         break;
       case 'action_delete':
-        // Customise message based on usage
-        let message = i18n._t('AssetAdmin.CONFIRMDELETE', 'Are you sure you want to delete this record?');
-        if (this.props.file && this.props.file.inUseCount > 0) {
-          message = i18n.sprintf(
-            i18n._t(
-              'AssetAdmin.BULK_ACTIONS_DELETE_SINGLE_CONFIRM',
-              'This file is currently used in %s place(s), are you sure you want to delete it?'
-            ),
-            this.props.file.inUseCount
-          );
-          message += '\n\n';
-          message += i18n._t(
-            'AssetAdmin.BULK_ACTIONS_DELETE_WARNING',
-            'Ensure files are removed from content areas prior to deleting them,'
-            + ' otherwise they will appear as broken links.'
-          );
-        }
-        // eslint-disable-next-line no-alert
-        if (confirm(message)) {
-          this.props.actions.unsavedForms.removeFormChanged('AssetAdmin.EditForm');
-          this.props.onDelete([data.ID]);
-        }
+        this.handleDelete(event, data);
         event.preventDefault();
 
+        break;
+      default:
         break;
     }
   }
@@ -114,6 +96,32 @@ class Editor extends Component {
     }
   }
 
+  handleDelete(event, data) {
+    // Customise message based on usage
+    let message = i18n._t('AssetAdmin.CONFIRMDELETE', 'Are you sure you want to delete this record?');
+    if (this.props.file && this.props.file.inUseCount > 0) {
+      message = i18n.sprintf(
+        i18n._t(
+          'AssetAdmin.BULK_ACTIONS_DELETE_SINGLE_CONFIRM',
+          'This file is currently used in %s place(s), are you sure you want to delete it?'
+        ),
+        this.props.file.inUseCount
+      );
+      message += '\n\n';
+      message += i18n._t(
+        'AssetAdmin.BULK_ACTIONS_DELETE_WARNING',
+        'Ensure files are removed from content areas prior to deleting them,'
+        + ' otherwise they will appear as broken links.'
+      );
+    }
+    // eslint-disable-next-line no-alert
+    if (confirm(message)) {
+      this.props.actions.unsavedForms.removeFormChanged('AssetAdmin.EditForm');
+      this.props.onDelete([data.ID]);
+    }
+    event.preventDefault();
+  }
+
   openModal() {
     this.setState({
       openModal: true,
@@ -137,7 +145,7 @@ class Editor extends Component {
 
   downloadFile() {
     function downloadURI(uri, name) {
-      const link = document.createElement("a");
+      const link = document.createElement('a');
       link.download = name;
       link.href = uri;
       link.target = '_blank';